Skip device if parent is a file and not a dir#33
Open
zestrada wants to merge 7 commits intobestouff:masterfrom
Open
Skip device if parent is a file and not a dir#33zestrada wants to merge 7 commits intobestouff:masterfrom
zestrada wants to merge 7 commits intobestouff:masterfrom
Conversation
AndrewFasano
force-pushed
the
master
branch
6 times, most recently
from
14d6f12 to
613425d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips creation of a device from the devtable file if the parent of that device is not a directory.
Ran into this when rebuilding a filesystem extracted from an existing image. We use a devtable to add back devices that might be missed during extraction. Sometimes you'll get stuff like
/dev/mtd0in the existing image but the default devtable has entries like/dev/mtd/0. This change allows genext2fs to be a little more robust in use cases like ours.