Skip to content

DAKEFPVF722 - Add USE_MAX7456 definition to config.h to fix analogue OSD#1124

Open
halfmanbear wants to merge 1 commit into
betaflight:masterfrom
halfmanbear:patch-1
Open

DAKEFPVF722 - Add USE_MAX7456 definition to config.h to fix analogue OSD#1124
halfmanbear wants to merge 1 commit into
betaflight:masterfrom
halfmanbear:patch-1

Conversation

@halfmanbear

@halfmanbear halfmanbear commented Jun 10, 2026

Copy link
Copy Markdown

Cloud builds for DAKEFPVF722: Analogue OSD was non-functional, as it lacked the USE_MAX7456 definition.

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • MAX7456 OSD support enabled for DAKEFPVF722 board.

Cloud builds: Analogue OSD was non-functional, as it lacked the USE_MAX7456 definition.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 14cae47e-3814-4cd3-92b0-cbae86a8b063

📥 Commits

Reviewing files that changed from the base of the PR and between 0373314 and 4d4f9fc.

📒 Files selected for processing (1)
  • configs/DAKEFPVF722/config.h

Walkthrough

The DAKEFPVF722 board configuration adds a single macro definition to enable MAX7456 OSD (on-screen display) support. This is a straightforward configuration change that activates hardware support for a specific OSD chipset on this flight controller board.

Changes

Board Configuration Enhancement

Layer / File(s) Summary
MAX7456 enable macro
configs/DAKEFPVF722/config.h
Adds #define USE_MAX7456 to activate MAX7456 OSD support on the DAKEFPVF722 board configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • betaflight/config#1088: Both PRs modify board config.h headers to enable MAX7456 OSD support via the USE_MAX7456 macro in the respective configurations.
  • betaflight/config#1061: Both PRs enable MAX7456 support by defining USE_MAX7456 in their respective configs/*/config.h files.
  • betaflight/config#995: Both PRs enable MAX7456 by defining the USE_MAX7456 macro in different board config.h files.

Suggested labels

Ready To Merge

Suggested reviewers

  • haslinghuis
  • ot0tot
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a brief explanation of the fix but does not fill out the PR template properly. The checklist items remain unchecked and critical compliance information is missing. Complete the checklist items to confirm hardware compliance, schematics review, testing completion, and issue resolution status. Provide specific details about the fix rather than leaving only template text.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding USE_MAX7456 definition to fix analogue OSD for the DAKEFPVF722 board configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants