Line-synced background vocals (#122) - #137
Draft
boidushya wants to merge 105 commits into
Draft
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
composer | 63ea05f | Commit Preview URL Branch Preview URL |
Jun 20 2026, 09:22 PM |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
boidushya
marked this pull request as draft
June 20, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background vocals are now a first-class voice with the same three-state timing model as the main vocal: untimed, line-synced, or word-synced. Previously a background on a line-synced line was automatically broken up into words. Now it stays a single line-synced block, matching how the main line behaves.
Re-lands the feature that was reverted in #136, with one added fix: the per-row group-tint overlay no longer swallows right-clicks on the background lane, so "Add word here" works on the bg lane of a line that has no background yet.
Closes #122.
What changed
LyricLinenests its timing into voices,{ main: Voice; background?: BackgroundVoice }, whereVoiceis a structural union (untimed{text}, line-synced{text,begin,end}, word-synced{text,words}). A single seam (domain/line/voices.ts) is the only reader of the nested fields, and a fitness test bans inline access elsewhere.x-bgspan imports as a line-synced background, two or more import as word-synced, and untimed text resolves against the main.x-bgspan with its own bounds, andcomposer:timingis derived from whether any voice is word-synced.pointer-events-none, so right-clicks reach the background lane beneath it.Testing