Skip to content

feat: New setting: Rolling edit mode affects syllable conjoining - #142

Open
lanye74 wants to merge 14 commits into
better-lyrics:masterfrom
lanye74:feat/rolling-affects-syllables
Open

feat: New setting: Rolling edit mode affects syllable conjoining#142
lanye74 wants to merge 14 commits into
better-lyrics:masterfrom
lanye74:feat/rolling-affects-syllables

Conversation

@lanye74

@lanye74 lanye74 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

In the timeline view, the rolling edit mode causes two adjacent words with no gap between them to act as if conjoined: pulling the end of one word forward in time will cause its sibling's start to move forward in time, such that there is never a gap between the words. When rolling edit mode is disabled, adjusting word boundaries solely affects that word.

However, when editing syllables, they always act as if rolling edit mode is enabled. This behavior can be manually overridden by pressing Alt to separate the syllable boundaries.

This PR introduces a toggle setting that allows syllables to also respect rolling edit mode, like words do. Namely: if the setting is enabled and rolling mode is disabled, syllables can be adjusted independently.

A note: This setting also respects alt-key inversion. While alt-key inversion is effectively useless in this context—since the user should be toggling rolling edit mode instead—I chose to leave it in order to mimic existing behavior and reduce logic changes :-)

demo.mp4

see conversation in discord

@lanye74
lanye74 force-pushed the feat/rolling-affects-syllables branch 2 times, most recently from 9a0d662 to 6438463 Compare June 26, 2026 06:08
@lanye74
lanye74 marked this pull request as ready for review June 26, 2026 10:10
@lanye74
lanye74 marked this pull request as draft June 26, 2026 10:12
@lanye74

lanye74 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

This PR is built off of #143, which is why there are duplicate commits here. After you merge #143, then I will rebase and mark as ready for review/merge. ^^

@lanye74
lanye74 force-pushed the feat/rolling-affects-syllables branch 2 times, most recently from 6739c4d to 6dcd1c6 Compare July 2, 2026 21:12
lanye74 added 14 commits July 6, 2026 02:10
(probably missed some spots)
really, i think this behavior shouldn't exist when rolling is on, but i don't want to break the existing logic too much

if the user knows and chooses to use it, then they can press alt, otherwise, they should just toggle rolling mode
@lanye74
lanye74 force-pushed the feat/rolling-affects-syllables branch from 6dcd1c6 to 02c431b Compare July 6, 2026 06:11
@lanye74
lanye74 marked this pull request as ready for review July 6, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant