feat: New setting: Rolling edit mode affects syllable conjoining - #142
Open
lanye74 wants to merge 14 commits into
Open
feat: New setting: Rolling edit mode affects syllable conjoining#142lanye74 wants to merge 14 commits into
lanye74 wants to merge 14 commits into
Conversation
lanye74
force-pushed
the
feat/rolling-affects-syllables
branch
2 times, most recently
from
June 26, 2026 06:08
9a0d662 to
6438463
Compare
lanye74
marked this pull request as ready for review
June 26, 2026 10:10
lanye74
marked this pull request as draft
June 26, 2026 10:12
Contributor
Author
lanye74
force-pushed
the
feat/rolling-affects-syllables
branch
2 times, most recently
from
July 2, 2026 21:12
6739c4d to
6dcd1c6
Compare
(probably missed some spots)
really, i think this behavior shouldn't exist when rolling is on, but i don't want to break the existing logic too much if the user knows and chooses to use it, then they can press alt, otherwise, they should just toggle rolling mode
lanye74
force-pushed
the
feat/rolling-affects-syllables
branch
from
July 6, 2026 06:11
6dcd1c6 to
02c431b
Compare
lanye74
marked this pull request as ready for review
July 6, 2026 06:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the timeline view, the rolling edit mode causes two adjacent words with no gap between them to act as if conjoined: pulling the end of one word forward in time will cause its sibling's start to move forward in time, such that there is never a gap between the words. When rolling edit mode is disabled, adjusting word boundaries solely affects that word.
However, when editing syllables, they always act as if rolling edit mode is enabled. This behavior can be manually overridden by pressing
Altto separate the syllable boundaries.This PR introduces a toggle setting that allows syllables to also respect rolling edit mode, like words do. Namely: if the setting is enabled and rolling mode is disabled, syllables can be adjusted independently.
demo.mp4
see conversation in discord