Feat/add datalist pagination styling pfr 1133#3890
Merged
jeroenreijs merged 6 commits intoedgefrom Mar 10, 2026
Merged
Conversation
Collaborator
Author
JorisPannekeet
previously approved these changes
Feb 17, 2026
jeroenreijs
reviewed
Feb 18, 2026
jeroenreijs
reviewed
Feb 18, 2026
jeroenreijs
reviewed
Feb 18, 2026
jeroenreijs
requested changes
Feb 18, 2026
Collaborator
jeroenreijs
left a comment
There was a problem hiding this comment.
Please take a look at my comments.
…ackwards compatibility
|
Requested changes have been applied |
jeroenreijs
requested changes
Feb 23, 2026
jeroenreijs
requested changes
Mar 9, 2026
jeroenreijs
reviewed
Mar 10, 2026
jeroenreijs
approved these changes
Mar 10, 2026
Collaborator
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
DataListpagination by making page navigation boundaries explicit and adding styling support for pagination alignment and color. The update prevents navigating beyond valid pages, keeps the pagination controls semantically correct, and allows pagination presentation to be configured through component options.Changes
Pagination behavior
Introduced a single, explicit
totalPagescalculation (Math.ceil(totalCount / rowsPerPage)).Added derived flags for navigation boundaries:
isPrevDisabled(disabled on page 1)isNextDisabled(disabled on the last page)Updated pagination controls to use the native
disabledattribute instead of conditionally rendering buttons vs. non-clickable icons.Kept the existing safety check that clamps
currentPagewhen the result set shrinks (e.g. after filtering/search changes).Pagination styling support
Added support for configuring pagination styling via options:
Applied these settings at the footer level so the pagination block aligns and inherits the configured color consistently.
Why
Previously, pagination boundaries were enforced through conditional rendering and a “next” comparison based on
totalCount / rowsPerPage, which can result in fractional comparisons and less readable logic. Disabled states were also represented by swapping elements rather than using button semantics.This PR:
totalPages) for clearer, predictable boundaries.<button disabled>.DataListpagination can match page design requirements without custom overrides.Testing
totalCountdecreases (e.g. after filter/search changes).