0.13: One-Shot system Improvements#909
Conversation
|
I think Nathan Fenner is the right call for who to credit there: the other PRs are pretty incidental. |
Nathan-Fenner
left a comment
There was a problem hiding this comment.
I left a few small notes.
From the technical side, I think it's cool that run_system(id) is now just the same as run_system_with_,input(id, ()) - bevy's generic types are quite magically expressive. It is a testament to Bevy's leveraging of Rust's type system just now easy this was to implement.
| } | ||
|
|
||
| let mut world = World::new(); | ||
| let id = world.register_system(increment_sys); |
There was a problem hiding this comment.
The type of id is slightly different now, it's a SystemId<i32, i32>, (though plain SystemId still works and now means SystemId<(), ()>) which might be worth mentioning- possibly also making the in/out types different in the example to clearly show which is which.
There was a problem hiding this comment.
For the sake of brevity, I think I'll leave it out of the main post, but I like the idea of adding type annotations and maybe a comment to the code example. I'll do that later.
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
For the release notes (#891).
@Nathan-Fenner, I'd love it if you could proofread the text (if you have the time) and let me know if everything is correct.
I have kept it purposefully short, as I don't see it as a particularly big change, just some QOL.
Also, I don't quite know who to credit. I'm currently referring to changes done in
World::run_systemto get system output bevy#10380 (significant work)and I've only really given credit to Nathan Fenner so far, as that amounts to the lion's share of the work.