Skip to content

fix: process window position before size in changed_windows #23248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mockersf merged 1 commit into from
Mar 9, 2026
Merged

fix: process window position before size in changed_windows #23248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions crates/bevy_winit/src/system.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,26 @@ pub(crate) fn changed_windows(
}
}

// Set position before size so the window is on the correct monitor
// (and thus using the correct scale factor) when size is applied.
if window.position != cache.position
&& let Some(position) = crate::winit_window_position(
&window.position,
&window.resolution,
&monitors,
winit_window.primary_monitor(),
winit_window.current_monitor(),
) {
let should_set = match winit_window.outer_position() {
Ok(current_position) => current_position != position,
_ => true,
};

if should_set {
winit_window.set_outer_position(position);
}
}

if window.resolution != cache.resolution {
let mut physical_size = PhysicalSize::new(
window.resolution.physical_width(),
Expand Down Expand Up @@ -444,24 +464,6 @@ pub(crate) fn changed_windows(
);
}

if window.position != cache.position
&& let Some(position) = crate::winit_window_position(
&window.position,
&window.resolution,
&monitors,
winit_window.primary_monitor(),
winit_window.current_monitor(),
) {
let should_set = match winit_window.outer_position() {
Ok(current_position) => current_position != position,
_ => true,
};

if should_set {
winit_window.set_outer_position(position);
}
}

if let Some(maximized) = window.internal.take_maximize_request() {
winit_window.set_maximized(maximized);
}
Expand Down