Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/bindings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@ jobs:
print(f"{d['lang']}: {len(d['results'])} cases OK")
PY
# Upload can hit intermittent FinalizeArtifact 403s from the Actions
# intermediary; retry a few times before failing the job. The runner
# assertions above already validated the binding itself.
# intermediary; retry before failing the job. The runner assertions above
# already validated the binding itself. A failed Finalize can still reserve
# the artifact name, so overwrite:true often 409s — use a distinct retry name
# that the equivalence job still picks up via results-*.
- name: Upload results
if: steps.has.outputs.ok == 'true'
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
Expand All @@ -160,10 +162,9 @@ jobs:
if: steps.has.outputs.ok == 'true' && steps.upload-results.outcome != 'success'
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: results-${{ matrix.lang }}
name: results-${{ matrix.lang }}-retry-${{ github.run_attempt }}
path: ${{ env.RW_OUT }}
if-no-files-found: error
overwrite: true

equivalence:
name: Cross-language equivalence
Expand Down
36 changes: 36 additions & 0 deletions python/rustwright/sync_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -24470,6 +24470,42 @@ def run_post_action_locator_handlers() -> None:
deadline = time.monotonic() + max(timeout_ms, 1.0) / 1000
self._page._run_locator_handlers(deadline)

use_legacy_click = (
forced
or bool(trial)
or getattr(self._page, "_active_page_cdp_event_contexts", 0) > 0
or any(
value is not None
for value in (modifiers, position, delay, button, click_count, steps)
)
)
if not use_legacy_click:
timeout_ms = _default_timeout_for_method(self._page, timeout, method=method)
mouse = self._page.mouse
on_poll = (
self._page._run_locator_handlers_for_remaining
if getattr(self._page, "_locator_handlers", None)
else None
)
target_x, target_y = _call(
self._page._core.locator_click_actionable,
_json(self._spec),
self._index,
bool(self._strict and not self._explicit_index),
timeout_ms,
mouse._x,
mouse._y,
mouse._buttons,
self._page.keyboard._modifiers_mask(),
on_poll,
)
mouse._x = float(target_x)
mouse._y = float(target_y)
mouse._buttons &= ~1
run_post_action_locator_handlers()
self._page._slow_mo()
return

target_info: Optional[dict[str, Any]] = None
if forced:
target_info = self._wait_for_forced_visible_pointer_action(
Expand Down
Loading
Loading