Skip to content

Make zparseopts section argument extraction more robust #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgreg merged 2 commits into from
Dec 22, 2025
Merged

Make zparseopts section argument extraction more robust #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c72f6
Initial plan
Copilot Dec 22, 2025
484601f
Make zparseopts section extraction more robust
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion goodmorning.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,13 @@ main() {

# Handle single section mode (skip all preflight and run just one function)
if [[ ${#section_arg[@]} -gt 0 ]]; then
local section_name="${section_arg[2]}"
# zparseopts stores option name at index 1 and value at index 2
# Use the last element to be more robust against zparseopts behavior changes
if [[ ${#section_arg[@]} -lt 2 ]]; then
echo "Error: --section requires a value" >&2
return 1
fi
local section_name="${section_arg[-1]}"
_run_single_section "$section_name"
return $?
fi
Expand Down