Skip to content

Optimize word of day fallback to single Swift invocation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgreg merged 4 commits into from
Dec 22, 2025
Merged

Optimize word of day fallback to single Swift invocation #5

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6faffc
Initial plan
Copilot Dec 22, 2025
18ebb03
Optimize word of day fallback to use single Swift invocation
Copilot Dec 22, 2025
4d61912
Address code review feedback: fix whitespace and improve parsing
Copilot Dec 22, 2025
b00d902
Improve awk parsing patterns for better robustness
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions lib/app/sections/word_of_day.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,27 @@ if let def = DCSCopyTextDefinition(nil, word as CFString, CFRangeMake(0, word.co
}
' -- "$word" 2>> "$LOG_FILE")

# If no definition found, try fallback words
# If no definition found, try fallback words in a single Swift invocation
if [[ -z "$definition" ]]; then
for fallback in "ephemeral" "serendipity" "eloquent" "resilient" "catalyst"; do
definition=$(swift -e '
local fallback_result
fallback_result=$(swift -e '
import Foundation
import CoreServices
let args = CommandLine.arguments
guard args.count > 1 else { exit(1) }
let word = args[1]
if let def = DCSCopyTextDefinition(nil, word as CFString, CFRangeMake(0, word.count))?.takeRetainedValue() as String? {
print(def)
let fallbackWords = ["ephemeral", "serendipity", "eloquent", "resilient", "catalyst"]
for word in fallbackWords {
if let def = DCSCopyTextDefinition(nil, word as CFString, CFRangeMake(0, word.count))?.takeRetainedValue() as String? {
print(word)
print("<<<DEFINITION_DELIMITER>>>")
print(def)
break
}
}
' -- "$fallback" 2>> "$LOG_FILE")
[[ -n "$definition" ]] && word="$fallback" && break
done
' 2>> "$LOG_FILE")

if [[ -n "$fallback_result" ]]; then
word=$(echo "$fallback_result" | awk 'BEGIN {found=0} /<<<DEFINITION_DELIMITER>>>/ {found=1; exit} !found {print}' | tr -d '\n')
definition=$(echo "$fallback_result" | awk 'BEGIN {found=0} /<<<DEFINITION_DELIMITER>>>/ {found=1; next} found {print}')
fi
fi

[[ -z "$definition" ]] && return 1
Expand Down