Skip to content

Use correct separator in keywords.txt#6

Open
per1234 wants to merge 1 commit intobhagman:masterfrom
per1234:keyword-separator
Open

Use correct separator in keywords.txt#6
per1234 wants to merge 1 commit intobhagman:masterfrom
per1234:keyword-separator

Conversation

@per1234
Copy link

@per1234 per1234 commented Sep 2, 2017

The Arduino IDE requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.

Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords

The Arduino IDE requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.

Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
@bhagman bhagman self-assigned this Sep 4, 2017
@bhagman
Copy link
Owner

bhagman commented Sep 4, 2017

Hey @per1234 -- I'm not sure who put you up to this, but damn... that's gotta be a LOT of work to fork and fix all of those libraries with messed up keywords.txt files.

How about instead, we just fix the problem with the keyword loading? It was done a long time ago in Wiring, but it seems that Arduino never picked it up.

I've made the change and created a pull request to the Arduino repo: arduino/Arduino#6693

@per1234
Copy link
Author

per1234 commented Sep 4, 2017

Good job on that pull request! I don't see any benefit to requiring tabs for the separator and it's a pain for people who have their editor set up to use spaces instead of tabs.

I do think it's still worth making this change for the sake of backwards compatibility. It's surprising how many people are still using outdated versions of the Arduino IDE going back to 1.0.5 or older.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants