Skip to content

Recaptcha#2896

Draft
jamesqquick wants to merge 13 commits intocanaryfrom
recaptch
Draft

Recaptcha#2896
jamesqquick wants to merge 13 commits intocanaryfrom
recaptch

Conversation

@jamesqquick
Copy link
Contributor

@jamesqquick jamesqquick commented Feb 20, 2026

What/Why?

Match functionality of Stencil with regards to reCAPTCHA. Catalyst should respect the reCAPTCHA settings from the Control Panel and apply reCAPTCHA to forms appropriately based on those settings.

CleanShot 2026-03-02 at 12 20 01@2x

Forms that should support reCAPTCHA if enabled include:

  • product reviews
  • user registration
  • contact

Testing

with reCAPTCHA enabled in the Control Panel

Register & contact

  • Submit without completing the reCAPTCHA checkbox → submission is blocked and “Please complete the reCAPTCHA verification.” is shown.
  • Complete reCAPTCHA and submit with valid data → form submits and succeeds as expected.

Product review

  • Open “Write a review” and submit without completing reCAPTCHA → same error, no submit.
  • Complete reCAPTCHA and submit → review submits and success toast appears.

without reCAPTCHA enabled in the Control Panel

When reCAPTCHA is disabled in the control panel, all three forms submit without a reCAPTCHA widget or “complete reCAPTCHA” errors.

Migration

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

⚠️ No Changeset found

Latest commit: 37e4938

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment Mar 4, 2026 1:26am

Request Review

Copy link
Contributor

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level, I think this is pretty good - the main "architectural" feedback I have is that it looks like you introduce two ways to get the recaptcha key but are only using one of them... wondering if that's redundant. I could be misunderstanding intent here, so I definitely encourage a second reviewer to weigh in!

Outside of this, my only other concern is the library is a bit old... not sure if it's being maintained, especially looking at some of the recent issues: dozoisch/react-google-recaptcha#301

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Bundle Size Report

Comparing against baseline from 8b5fee6 (2026-03-04).

Metric Baseline Current Delta
Total JS 505.2 kB 509.1 kB +3.9 kB (+0.8%)

Per-Route First Load JS

Route Baseline Current Delta
/(default)/(auth)/register/page 351.5 kB 355.2 kB +3.7 kB (+1.1%)
/(default)/account/addresses/page 358.1 kB 361.9 kB +3.8 kB (+1.1%)
/(default)/gift-certificates/purchase/page 357.7 kB 361.5 kB +3.8 kB (+1.1%)
/(default)/product/[slug]/page 378.5 kB 382.3 kB +3.8 kB (+1%)
/(default)/webpages/[id]/contact/page 356.2 kB 360 kB +3.8 kB (+1.1%)

Threshold: 5% increase. Routes with ⚠️ exceed the threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants