refactor(core): split client into base config and extended client#2906
Closed
matthewvolk wants to merge 1 commit intocanaryfrom
Closed
refactor(core): split client into base config and extended client#2906matthewvolk wants to merge 1 commit intocanaryfrom
matthewvolk wants to merge 1 commit intocanaryfrom
Conversation
Extract shared client configuration into a framework-agnostic `base.ts` module so `next.config.ts` no longer transitively imports `next/headers`, `next/navigation`, or `next-intl/server`. This prevents AsyncLocalStorage poisoning during config resolution in Next.js 16.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Author
|
Closing in favor of #2905 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/client/base.tsmodulecore/next.config.tsto importbaseClientfrom./client/baseinstead ofclientfrom the barrel./clientcore/client/index.tsto spreadbaseClientConfiginstead of duplicating config fieldsMotivation
In Next.js 16,
core/client/index.tsstatically importsnext/headers,next/navigation, andnext-intl/server. Whennext.config.tsimports this module, those imports poison the process-wide AsyncLocalStorage context, causing "workUnitAsyncStorage" invariant errors at runtime.This is Approach B from CATALYST-1808. Compared to the dynamic-imports approach in PR #2905 (Approach A), this approach:
import()on every requestindex.tsexactly as-isTest plan
pnpm tsc --noEmitincore/— no new type errorspnpm build— Next.js config resolution works without AsyncLocalStorage errorsnext.config.tsno longer imports from./clientbarrel~/clientcontinue working unchanged