Skip to content

Conversation

@heka1024
Copy link
Contributor

What? Why?

I saw this deprecation warning in our codebase.

DEPRECATION WARNING: `clear_active_connections!` currently only applies to connection pools in the current role (`writing`). In Rails 7.2, this method will apply to all known pools, regardless of role. To affect only those connections belonging to a specific role, pass the role name as an argument. To switch to the new behavior, pass `:all` as the role name.

How was it tested?

  • From my company's internal fork

Copy link

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@terranisu
Copy link

Hey @splittingred, sorry for bothering you but do you think this PR could be accepted any time soon?

We also use a similar patch in our Gruf-based projects. However, it would be awesome to have the deprecation warning fixed in the origin 😅

Copy link

@khaled-scribd khaled-scribd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@splittingred
Copy link
Member

hey @heka1024 can you add a note to CHANGELOG.md with this change? (also, rebase to latest, and this will kickoff a new CI suite run so we can get to green here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants