Revert go-micro.dev/v5 to v5.3.0 - #102
Closed
ambersun1234 wants to merge 2 commits into
Closed
ambersun1234 wants to merge 2 commits into
ambersun1234 wants to merge 2 commits into
Conversation
#90's grouped minor-and-patch bump took go-micro.dev/v5 from 5.3.0 to 5.30.0 along with 21 unrelated packages. Somewhere in that range, go-micro.dev/v5 dropped the util/addr package, which github.com/micro/plugins/v5/server/http@v1.0.2 still imports -- v1.0.2 is the latest release of that plugin, so there's no forward fix. This repo itself only touches go-micro.dev/v5/logger (pkg/log, pkg/openstack), never util/addr or the http server plugin, so pinning back to 5.3.0 doesn't affect anything this repo actually does with it. But any downstream consumer that also depends directly on micro/plugins/v5/server/http (e.g. cubecmp) gets go-micro.dev/v5 dragged up to 5.30.0 transitively via Go's minimal version selection the moment it updates this module -- which breaks their build with no way to fix it on their end. go mod tidy only touched the two go-micro.dev/v5 lines plus a handful of already-resolved transitive checksums; none of #90's other 21 package bumps are affected. Signed-off-by: Shawn Hsu <shawn.hsu@bigstack.co> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
go.mod was bumped to require go 1.26.0 (2026-09-07's minor-and-patch dependency update), but ci.yaml still hard-pinned actions/setup-go to 1.25 -- GOTOOLCHAIN=local means it never auto-upgrades, so the mockery step has failed with "go.mod requires go >= 1.26.0" on every PR since, this one included. Switching to go-version-file avoids the same drift happening again next time go.mod's Go version moves. Signed-off-by: Shawn Hsu <shawn.hsu@bigstack.co> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
arasHi87
approved these changes
Sep 11, 2026
Author
|
Superseded by #101, which already merged this exact go-micro.dev/v5 v5.3.0 pin fix (plus the ci.yaml go-version-file fix) — confirmed by rebasing this branch onto develop and finding it now has zero commits ahead / zero diff, since both commits here became empty against develop's current state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
Reverts
go-micro.dev/v5from5.30.0back to5.3.0.#90's grouped minor-and-patch bump took
go-micro.dev/v5from5.3.0to5.30.0along with 21 unrelated packages. Somewhere in that range,go-micro.dev/v5dropped theutil/addrpackage, whichgithub.com/micro/plugins/v5/server/http@v1.0.2still imports —v1.0.2is the latest release of that plugin, so there's no forward fix available.This repo itself only touches
go-micro.dev/v5/logger(pkg/log,pkg/openstack), neverutil/addror the http server plugin, so pinning back to5.3.0doesn't affect anything this repo actually does with it. But any downstream consumer that also depends directly onmicro/plugins/v5/server/http(e.g.cubecmp) getsgo-micro.dev/v5dragged up to5.30.0transitively via Go's minimal version selection the moment it updates this module — which breaks their build with no way to fix it on their end.go mod tidyonly touched the twogo-micro.dev/v5lines plus a handful of already-resolved transitive checksums; none of #90's other 21 package bumps are affected.Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Found this while trying to pull #101 into
cubecmp—go build ./...failed there withno required module provides package go-micro.dev/v5/util/addr.Additional documentation