feat(tuning): register nova.nested.virt.enabled for the compute roles - #642
Merged
Merged
Conversation
traviswu-bigstack
force-pushed
the
feat/nova-nested-virt-tuning
branch
from
September 1, 2026 10:54
ff4faf9 to
1e5b93e
Compare
traviswu-bigstack
marked this pull request as ready for review
September 1, 2026 11:02
raven-pan
approved these changes
Sep 10, 2026
Eandalf-Bigstack
approved these changes
Sep 15, 2026
Signed-off-by: Travis Wu <travis.wu@bigstack.co>
Eandalf-Bigstack
force-pushed
the
feat/nova-nested-virt-tuning
branch
from
September 15, 2026 06:59
1e5b93e to
28cdf6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #648.
Registers the
nova.nested.virt.enabledtuning introduced by bigstack-oss/cubecos#1365 (the fix for bigstack-oss/cubecos#1361) so the API advertises it against the roles that actually apply it.tuningToRoles[NovaNestedVirtEnabled] = nodes.ComputeRoles— {compute, control-converged, edge-core}.Why
The tuning's only effect is
cpu_model_extra_flagsin nova.conf's[libvirt]section, written underif (IsCompute(s_eCubeRole))inconfig_nova.cpp— so control-only, storage and moderator nodes never act on it. Without an entry in the map,getTuningRolesfalls back tonodes.AllRoles(tuning.go:452), which would advertise it on nodes where libvirt does not run.ComputeRolesmatches the sibling hypervisor-scoped tunings (nova.gpu.type,nova.control.host.memory). It is deliberately narrower thannovaLiveResizeRoles, which includes control and moderator because live-resize also constrains nova-api/scheduler behaviour; nested virt does not.The value must be uniform cluster-wide, which this role set expresses: every compute-capable node applies the same setting. A host exposing vmx while its peers mask it would hand a migrated guest a different CPU than it booted with — the same class of inconsistency cubecos#1365 exists to prevent.
Reviewer notes
docs.yamlchange: the tuning entries there are illustrative response examples, not a validating enum, and they already omit thenova.live.resize.*family — adding only this one would be inconsistent. Say the word if you would rather the examples be exhaustive.hex_sdk tuning_dump; until thensetTuningSpecssimply never sees the name and the map entry is inert, so merge order does not matter.Docs
Behaviour is documented by cubecos#1365's handbook note; no separate handbook change proposed here.