feat(health): add advisor as a repairable clusterSys module - #660
Draft
traviswu-bigstack wants to merge 1 commit into
Draft
traviswu-bigstack wants to merge 1 commit into
traviswu-bigstack wants to merge 1 commit into
Conversation
Cube AI Advisor agent health/repair is landing in cubecos (#1485). Add advisor to OrderSensitiveServices' clusterSys, after license, so it appears in the health view and cluster check_repair can restart its agent. Bumps the cube-cos-openapi submodule for the matching moduleType enum additions. Signed-off-by: Travis Wu <travis.wu@bigstack.co> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
Declares
advisoras a health module so CubeCOS's new Advisor check reaches the UI. The component list here is hardcoded and an unknown name returns 400, so without this the check exists in cubecos and is invisible everywhere else.It is marked repairable because cubecos provides
health_advisor_repair, which starts the agent's unit — socluster check_repaircan fix it manually or automatically. It is placed last inclusterSys;OrderSensitiveServicesis named for its order, which is the display order, so appending avoids moving anything that exists.Which issue(s) this PR fixes
Fixes #659
Special notes for your reviewer
Merge order matters.
api/cube-cos-openapiis a submodule and this commit bumps its pointer. Merge bigstack-oss/cube-cos-openapi's PR first, then repoint this at the merged sha.api/docs.jsonis git-ignored — a build artifact, regenerated by CI's pinnedyq -o=json -I=4, so there is nothing to commit for it here.Verified with a throwaway test (deleted before committing) that
Modules["advisor"]exists,IsRepairableis true, andclusterSys/advisorresolves as a valid pair —Modulesis built fromOrderSensitiveServicesat the bottom of the file, so that is the thing worth proving rather than reading.Additional documentation
🤖 Generated with Claude Code
https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj