Non-blocking hardening items from the advisor-module final review (PR #73 ), all triaged stays-deferred:
CMP app_register false positive : switch the cmp app_register step to hex_sdk app_import like advisor's, or revert both to hex_cli once [Bug] hex_cli app_register reports success even when the app import fails cubecos#1325 lands.
appfw lbSweep exit status : the sweep ends [ "$found" = 0 ] && echo … — exits 1 exactly when it DID sweep something; port the advisor sweep's exit 0 fix.
shellcheck in CI for internal/enterprise/assets/*.sh (the grep -c under set -e bug class).
UninstallModal hardcoded Project/Framework: 'appfw' — wrong for any module installed on a non-default framework name.
plan.go advisor steps : advisor_register targets p.Framework, install_advisor passes p.Project — align for raw-API callers with Project != Framework.
DB password via k8s $(VAR) args is visible in in-container /proc cmdline (cube-advisor chart) — move to env-read flags.
🤖 Generated with Claude Code
https://claude.ai/code/session_01E5EppnHrpbAYHCxPjN7t64
Non-blocking hardening items from the advisor-module final review (PR #73), all triaged stays-deferred:
app_registerstep tohex_sdk app_importlike advisor's, or revert both to hex_cli once [Bug] hex_cli app_register reports success even when the app import fails cubecos#1325 lands.[ "$found" = 0 ] && echo …— exits 1 exactly when it DID sweep something; port the advisor sweep'sexit 0fix.grep -cunderset -ebug class).Project/Framework: 'appfw'— wrong for any module installed on a non-default framework name.advisor_registertargetsp.Framework,install_advisorpassesp.Project— align for raw-API callers with Project != Framework.🤖 Generated with Claude Code
https://claude.ai/code/session_01E5EppnHrpbAYHCxPjN7t64