feat(enterprise): issue the console CA and name the account it authorises - #115
Merged
Merged
Conversation
…ises A chart-deployed Advisor logged "console: disabled (no -console-account)" and no console session could open. The chart gained the two values it needs (cube-ai-advisor#223); this supplies them. The CA is generated once and passed back on every upgrade, exactly as the enrollment CA already is, and for a sharper reason than symmetry: advisor-api generates one at startup when the chart passes none, and a CubeCOS node pins that CA in sshd and keeps it across firmware upgrades. A CA regenerated on the next pod restart therefore stops every already-enrolled node from accepting console certificates -- silently, because sshd simply stops accepting them and nothing on the Advisor notices. An unreadable existing key is refused rather than replaced. The account defaults to "advisor", which CubeCOS already provisions for exactly this; passing an empty one leaves the console off, which is what every install did before. Nothing pushes the CA to a node: the Advisor mints certificates and the node decides whether to accept them. So the install ends by printing the CA and the hex_cli command that installs it, rather than leaving an operator to discover that the console silently authenticates nobody. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj Signed-off-by: Travis Wu <travis.wu@bigstack.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
A chart-deployed Advisor logged
console: disabled (no -console-account)and no console session could open. The chart gained the two values it needs in bigstack-oss/cube-ai-advisor#223; this supplies them.advisor, which CubeCOS already provisions for exactly this. An empty account leaves the console off, which is what every install did before.Which issue(s) this PR fixes
The driver half of bigstack-oss/cube-ai-advisor#222.
Special notes for your reviewer
Why carrying the CA matters more than symmetry with the enrollment CA.
advisor-apigenerates a console CA at startup when the chart passes none. A CubeCOS node pins that CA in sshd at/etc/ssh/console-ca/cube-advisor.puband keeps it across firmware upgrades (CONFIG_MIGRATE(advisor, ADVISOR_CONSOLE_CA)), so a CA regenerated on the next pod restart stops every already-enrolled node from accepting console certificates — silently, because sshd simply stops accepting them and nothing on the Advisor notices. An unreadable existing key is refused rather than replaced.Nothing pushes the CA to a node, by design: the Advisor mints certificates and the node decides whether to accept them. So the install ends by printing the CA and the
hex_cli -c advisor -c console_trustline, rather than leaving an operator to discover that the console silently authenticates nobody. The node-side command is in the cubecos PR (#1482).Ordering for a working console: this PR + cube-ai-advisor#223 + cubecos#1482. Any one alone leaves the console non-functional, and #223 must land before an install here can pass
console.accountto a chart that understands it.Additional documentation
🤖 Generated with Claude Code
https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj