Drop monasca and senlin from the schema - #112
Merged
Merged
Conversation
This was referenced Sep 11, 2026
Merged
SekiXu
approved these changes
Sep 12, 2026
SekiXu
left a comment
Contributor
There was a problem hiding this comment.
Approving. Both removals are the schema catching up to code that already moved, which is the direction that cannot break a client of a shipped build:
- senlin — already absent from
cube-cos-api(git grep -i senlinonjim.lin/fix/drop-monascareturns nothing), andsenlin.debug.enabledis already gone fromcubecos/develop. So the schema was the stale copy, not the leading edge. - monasca — matches cube-cos-api#656 and cubecos#1457 exactly: the
metricsmodule group losesmonascaand keepstelegraf/grafana, the two module-name enums drop it, andmonasca.debug.enabledgoes at the same time cubecos#1457 deletes theCONFIG_TUNING_BOOLthat registers it.
Worth knowing for the merge: this is a clean fast-forward from develop, so a true ff merge puts develop on 3d9065db — which is what cube-cos-api#656 already pins its submodule at. That order works without a re-pin.
Monasca was removed from CubeCOS by bigstack-oss/cubecos#672 phase 4. Four places in the schema still described it as something the API can report on or an operator can tune: the metrics module group listed monasca alongside telegraf and grafana, so a client rendering that group showed a module the cluster no longer has. prometheus and thanos moved to the metricsDb group in a34418d; this is the other half of that tidy-up. two module name enums GET /v1/modules and the repair endpoint both accepted "monasca" as a valid module name. monasca.debug.enabled a documented tuning for a service with nothing left to configure. Schema only -- no endpoint, response shape or field changes, and docs.yaml still parses. The api/docs.json regeneration and the module list in Go live in cube-cos-api and land with the submodule bump there. Signed-off-by: Jim Lin <jim.lin@bigstack.co> Co-authored-by: Eandalf <clinah@connect.ust.hk> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Senlin was removed from CubeCOS by d4550c91, back on the yoga train. The schema
was only half-updated at the time: senlin came out of the module-name enums but
stayed in two other places, which is why every generated SDK is already clean
while the schema still describes the service.
the businessLogic module list the services example still showed senlin
beside watcher. cubecos' cluster check now
reports BusinessLogic as watcher alone.
senlin.debug.enabled a documented tuning for a service that has
not shipped for two release trains.
Neither feeds the TypeScript generator -- one is a response example, the other
a tuning document -- so consumers see no SDK change from this, only a schema
that stops advertising something that is gone.
Same shape as the monasca removal in the previous commit, and found while
doing it.
Signed-off-by: Jim Lin <jim.lin@bigstack.co>
Co-authored-by: Eandalf <clinah@connect.ust.hk>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Eandalf-Bigstack
force-pushed
the
jim.lin/fix/drop-monasca
branch
from
September 14, 2026 04:52
3d9065d to
6217dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes?
Part of bigstack-oss/cubecos#772, specifically bigstack-oss/cubecos#771 (COS UI > Home > Health page after the OpenStack, InfluxDB and Ceph upgrade).
What this PR does?
Removes two services from the schema that CubeCOS no longer ships, so the API stops describing things that are gone.
monasca — removed from CubeCOS by bigstack-oss/cubecos#672 phase 4. Four places still described it:
metricsmodule groupmonascabesidetelegrafandgrafana, so a client rendering that group showed a module the cluster does not haveGET /v1/modulesand the repair endpoint both accepted"monasca"as a valid module namemonasca.debug.enabledsenlin — removed from CubeCOS by
d4550c91, back on the yoga train. The schema was only half-updated at the time: senlin came out of the module-name enums but stayed in thebusinessLogicmodule list and in asenlin.debug.enabledtuning. That asymmetry is why every generated SDK is already clean while the schema still advertised the service. CubeCOS' own cluster check now reportsBusinessLogicaswatcheralone.Schema only — no endpoint, request or response shape changes.
Test results (optional)
1).
docs.yamlstill parses as YAML after both removals, andgrep -c monasca/grep -c senlinreturn 0.2). Regenerating the TypeScript SDK from this schema in cube-cos-ui produces:
@typeunions and two enum members removed — the exact mirror of whata34418dadded formetricsDbsdk/api.tsbyte-for-byte unchanged, which is the evidence that senlin was already absent from the module enums and only the non-generating parts of the schema still mentioned it3). Regenerating
api/docs.jsonin cube-cos-api from this schema yields zero monasca and zero senlin references. That file is embedded into the binary viaapi/docs.go'sgo:embed, so this schema change does reach the shipped artifact.Companion PRs
This PR is the base for the other two; both pin their submodule at this branch and want re-pinning to the merged SHA before they land.
🤖 Generated with Claude Code