feat(health): add advisor to the moduleType enum - #114
Draft
traviswu-bigstack wants to merge 1 commit into
Draft
traviswu-bigstack wants to merge 1 commit into
traviswu-bigstack wants to merge 1 commit into
Conversation
Cube AI Advisor agent health/repair is landing in cubecos (#1485). Add advisor to both moduleType path-param enums so the health and repair endpoints accept it. Signed-off-by: Travis Wu <travis.wu@bigstack.co> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
CubeCOS's
cluster checkframework is gaining anadvisorcomponent — it reports whether a node enrolled with the Cube AI Advisor still has its agent running (bigstack-oss/cubecos#1483).cube-cos-apideclares it as aclusterSysmodule, which requires the name to be valid in this spec.Which issue(s) this PR fixes
Part of bigstack-oss/cube-cos-api#659
Special notes for your reviewer
There are two
moduleTypeenums indocs.yaml. Both are updated. Adding the name to only one leaves one endpoint accepting it while the other returns 400 — which reads as correct in a diff and fails in exactly half the cases.Additional documentation
🤖 Generated with Claude Code
https://claude.ai/code/session_01PZ5umjjCedZwWtbAbiMjfj