Correct the logrotate owner in the CubeCOS operations chapter - #295
Merged
Merged
Conversation
Signed-off-by: arashi.li <arashi.li@bigstack.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
No ticket — a one-row correction found while writing the QA verification for #113
(already closed), not worth its own task.
What & why
docs/operations/cubecos.md's on-disk table credits/etc/logrotate.d/lachesisto theRPM. It isn't ours:
rpm -ql lachesison a live node does not list the file, andinit/lachesis.specnever installs it —
%filescovers the binary, the unit, the config, the LICENSE andthe two directories, nothing else.
static LogRotateConf log_conf(NAME, "/var/log/lachesis/*.log", DAILY, 128, 0, true);and
WriteLogRotateConf(log_conf)incore/modules/config_lachesis.cpp(cubecos).So its owner is
config_lachesis, the same as the rendered yaml two rows above.The distinction is the whole point of that column: a
hex_config-owned file comes backat the next commit after an operator deletes it, an RPM-owned one does not. Getting it
wrong sends someone reinstalling a package to restore a file that would have healed on
its own.
Test plan
go test ./internal/docs/(the doc-reference guard; no heading changed, sono citation needed updating)
Live validation
CubeCOS 1cc from pipeline build 9 (
cc1, control-converged, kernel6.12.95-1.el9,lachesis-v0.1.0-1.el9.6e42a6a), 2026-08-05:No logrotate entry — while
/etc/logrotate.d/lachesisis present on that node and hasbeen rotating correctly for six days (
lachesis.log.1throughlachesis.log.6.gz).Full run in #113's test report comment.
Scope / deliberately not touched
Only the owner cell. The rotation policy described in the same row (daily,
copytruncate,128M, compressed) matches
LogRotateConf(NAME, …, DAILY, 128, 0, true)and the file ondisk, so it stays as written.
Notes
Docs only — no contract in
docs/architecture/contracts.mdis affected.DoD
(bigstack-handbook#173, bigstack-handbook#185); this correction is small enough that
the handbook's lachesis operations runbook, which does not mention logrotate, needs
no change.