Skip to content

feat(dashboard): Add animated audio process and device mute controls - #110

Merged
bigtomcat6 merged 15 commits into
mainfrom
feat/audio-volume-mute-binding
Jul 18, 2026
Merged

feat(dashboard): Add animated audio process and device mute controls#110
bigtomcat6 merged 15 commits into
mainfrom
feat/audio-volume-mute-binding

Conversation

@bigtomcat6

@bigtomcat6 bigtomcat6 commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

This PR brings the Audio Dashboard controls into parity with real mute and volume semantics by:

  • Introducing an effective-volume state model for process- and device-level controls.
  • Animating mute transitions and zero-volume presentation so mute state is visually and functionally synchronized.
  • Improving control-readback behavior when device capabilities or control state become temporarily unavailable.
  • Hardening control lifecycle handling to avoid stale control/notification races.
  • Adding regression coverage for audio dashboard and coordinator state transitions.

How to test

  • git status --short
  • git diff --stat origin/main...HEAD
  • git log --oneline origin/main..HEAD
  • swift test --enable-code-coverage --cache-path /tmp/swiftpm-cache --scratch-path /tmp/swiftpm-build (not run in this PR draft)
  • Manual smoke test: open the Audio dashboard, toggle process and device mute/volume controls, and verify mute/restore transitions and control state updates are consistent.

Release impact

  • Type: Added
  • Release note: Added animated, resilient audio volume controls with better mute/volume-state handling and added regression coverage for audio dashboard state transitions.

Checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title follows type(scope): Summary.
  • Tests or a clear manual verification path are included.
  • User-facing changes include release-note wording or Release impact: None.

@bigtomcat6 bigtomcat6 added the feature PR Label label Jul 18, 2026
@bigtomcat6

Copy link
Copy Markdown
Owner Author

@codex review

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c1db75dd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/MacActivityApp/Models/AudioControlCoordinator.swift Outdated
@bigtomcat6 bigtomcat6 self-assigned this Jul 18, 2026
@bigtomcat6
bigtomcat6 marked this pull request as ready for review July 18, 2026 04:09

@bigtomcat6 bigtomcat6 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@bigtomcat6
bigtomcat6 merged commit ef5fab1 into main Jul 18, 2026
14 of 15 checks passed
@bigtomcat6
bigtomcat6 deleted the feat/audio-volume-mute-binding branch July 18, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PR Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant