Adopt the Bike Shaving house style - #386
Open
brainkim wants to merge 13 commits into
Open
Conversation
brainkim
force-pushed
the
chore/b9g-eslint-config
branch
3 times, most recently
from
August 28, 2026 07:12
cd4e509 to
deb711c
Compare
libuild 0.2.20 implements .each on node, so the cases run on both platforms with per-case reporting restored. 126 passed on bun and node. This reverts commit c377f5b. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Replaces ESLint 8, .eslintrc.json and prettier with the flat house config, and applies its autofixes across the repo. Overrides mirror the old config's intent: examples stay space-indented, and tests keep the crank plugin's component rules off. Two repo-specific settings: empty single-extends interfaces are allowed because ProvisionMap, EventMap and ChildIterable are extension points, and tagged templates are allowed as statements because tests invoke the jsx tag to assert it throws. One rule is off for tests: the jsx-curly-brace-presence fixer joins adjacent string expression children into a single text node, which changes rendered output that the tests assert exactly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Explicit return types on every function declaration and exported component; real signatures for the remaining bare Function types; ACROCase renames; deep optional chains flattened into named locals; catch clauses bind their errors; reasoned inline disables for the class/interface declaration merging behind Element and Context and for the empty extension-point interfaces in the global Crank namespace. crankdown's Marked returns Array<Element | string>, its real return type. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
brainkim
force-pushed
the
chore/b9g-eslint-config
branch
from
September 5, 2026 01:16
deb711c to
9ef6606
Compare
Reformats the repo under the new esfold/breaks rule (eslint-plugin-esfold 0.1.5, whose fixer now converges) and answers the new design rules: Element's members move from its merged interface into the class body, the event method typings move from Context's merged interface into the class, and the symbol slots on Context and CustomEventTarget move into their merged interfaces. The examples override gains indent-binary-ops to match its 2-space indent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Stars now bind to the name (*[Symbol.iterator], async *[Symbol.asyncIterator]). With @b9g/no-symbol-fields removed, the symbol slots return to class-body declare fields, which drops Context's generic merged interface and its unused-vars disable, and restores the inline handleEvent union now that esfold 0.1.6 tiles it correctly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
The indent rule no longer has an opinion on class heritage clauses, so the continuation line takes one level of indentation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
The isHuggable fix unhugs object-pattern parameters which carry a type literal, and long string arguments wrap again instead of joining past the line limit. The indent carveouts do not rewrite existing code, so the stair-stepped ternary chains and the cascaded scope assignment are hand-flattened to the fresh-format shapes. JSX chains keep the staircase by design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
One-parameter signatures returning a union break at the parameter list again instead of stranding the union's tail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the Bike Shaving house style (
@b9g/eslint-config@0.1.2) across the repo, replacing ESLint 8 +.eslintrc.json+ prettier with the flat config. Also restores theit.eachtests, per request.Note: this branch includes #385's two commits (it stacks on the bare-
Functionfix). Merging #385 first keeps this diff honest; a rebase after will drop the duplicates automatically.What's in here
it.eachrestored — reverts the nine for-of conversions from Run the package test suites through libuild #376. libuild 0.2.20 implements.eachon node, so both platforms report 126 passed with per-case reporting back.eslint.config.jsimporting@b9g/eslint-config, prettier and its plugins removed. The lint script is justeslint ..array-simple, quotes, comment style, declaration padding).oldHTMLValue,noReactSVGProps,escapeXML,iframeId, …), deep optional chains flattened, catches bind their errors, bareFunctionstragglers in tests typed.Repo-level overrides (mirroring the old config's intent, plus three discoveries)
.eslintrc.json.jsx-one-expression-per-linesplits adjacent text/expressions across lines (turned"render 2"into"render2"in a test),jsx-curly-brace-presencerewrites{"a"}children into whitespace-joined text (broke a hydration test), andconsistent-type-importsconverts the classic JSX factory import toimport typebecause it can't see compiled usage. Worth knowing for other Crank projects adopting the config.no-empty-object-typeallows single-extends interfaces (the ProvisionMap/EventMap/ChildIterable extension points);no-unused-expressionsallows tagged templates (tests invokejsxto assert it throws).Element,Context) and the global-namespace extension points carry reasoned inline disables.Verification
.eachrestored).Markedannotation had to beArray<Element | string>, its true return type.eslint .fully clean; roottsc --noEmitclean.tscfailures there (import attributes vs its tsconfig) are untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_019pggktip8wsuxzy2VCY9p7