-
-
Notifications
You must be signed in to change notification settings - Fork 1
Move image storage from Postgres bytea to Supabase Storage #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ThatXliner
wants to merge
11
commits into
main
Choose a base branch
from
use-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0a725b0
feat(db): add Supabase Storage abstraction and imageUrl column
ThatXliner 136d479
feat(scraper,api): upload images to object storage instead of bytea
ThatXliner 025e1fb
chore: rename imageUri to imageUrl, add migration script and env vars
ThatXliner 1c982f6
address review comments
ThatXliner 4994ccc
fix(scraper): don't delete uploaded image on DB update failure
ThatXliner 6a49c05
Format
ThatXliner db49802
Fix code review issues
ThatXliner 17d76c7
NO DOCS
ThatXliner 33c3dec
:bug: fix(storage): defer env read to call time
ThatXliner 152a24c
:bug: fix(scraper): clear legacy image columns on upload
ThatXliner 7966e8b
:pencil2: fix(db): correct schema comment for image fields
ThatXliner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUPABASE_SERVICE_ROLE_KEYis a highly-privileged secret; since this file is a template that often gets copied into multiple environments, it would help to explicitly note that this key must only ever be used server-side (never in Expo/browser code) and should be kept out of any client-exposed env var mechanisms.