Skip to content

fixed bug where certain failed scheduled tasks were not recorded #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srinathreddydudi merged 1 commit into from
Apr 25, 2026
Merged

fixed bug where certain failed scheduled tasks were not recorded #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 11 additions & 25 deletions src/Recorders/ScheduledTaskRecorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ class ScheduledTaskRecorder extends Recorder

public static $events = [
ScheduledTaskStarting::class,
ScheduledTaskFinished::class
ScheduledTaskFinished::class,
ScheduledTaskSkipped::class,
ScheduledTaskFailed::class
];

/**
Expand All @@ -42,11 +44,17 @@ public function trackEvent($event)
if ($event instanceof ScheduledTaskStarting ) {
$this->start($event);
} elseif ($event instanceof ScheduledTaskFinished ) {
$this->finish($event);
$event = $event->task;
if($event->exitCode === 0) {
$this->completeScheduledTask($event, 'completed');
} else {
$this->completeScheduledTask($event, 'failed');
}
} elseif ($event instanceof ScheduledTaskSkipped ) {
$this->skip($event);
} elseif ($event instanceof ScheduledTaskFailed ) {
$this->fail($event);
$event = $event->task;
$this->completeScheduledTask($event, 'failed');
}
}

Expand Down Expand Up @@ -83,18 +91,6 @@ public function start(ScheduledTaskStarting $event)
$this->laritor->pushEvent(static::$eventType, $payload);
}

/**
* Handle the event.
*
* @param ScheduledTaskFinished $event
* @return void
*/
public function finish(ScheduledTaskFinished $event)
{
$event = $event->task;
$this->completeScheduledTask($event, 'completed');
}

/**
* @param ScheduledTaskSkipped $event
* @return void
Expand Down Expand Up @@ -126,16 +122,6 @@ public function skip(ScheduledTaskSkipped $event)
$this->sendEvents();
}

/**
* @param ScheduledTaskFailed $event
* @return void
*/
public function fail(ScheduledTaskFailed $event)
{
$event = $event->task;
$this->completeScheduledTask($event, 'failed');
}

public function completeScheduledTask($event, $status)
{
$scheduledTasks = collect( $this->laritor->getEvents(static::$eventType))
Expand Down
Loading