Autosave changes of forms' sections #188#196
Open
annapakula wants to merge 4 commits into
Open
Conversation
adam-sas-on
reviewed
Mar 12, 2021
|
|
||
| let newSections2 = newSections.map( (section) => { | ||
| if(section.hasOwnProperty('isNew') ) | ||
| section.isNew = false; |
Member
There was a problem hiding this comment.
It was (still is) necessary to set the section not being new when the POST request was done as it is not new on the server anymore. By removing/commenting this you make the request being constantly POST for already created sections so whenever yous clicks "Zapisz pytania" the server will duplicate them. We are working on this duplication and it is issue #180 .
So in short: it makes the request being POST only once and only for sections the user created by click of corresponding button on the right panel.
Collaborator
Author
There was a problem hiding this comment.
Ok, I didn't notice duplication on my computer. I will redo this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.