fix(lazy): stop disabling native matchparen and matchit#7
Merged
Conversation
Disabling them saved roughly a millisecond of startup but silently removed behavior stock Neovim users expect: highlighting the matching bracket and extended % matching. Nothing in core replaced either, which contradicted the native-first contract. The remaining disabled plugins are dead weight or explicitly replaced (netrw by Oil). Documented in NEWS.md with the vim.g.loaded_* opt-out for users who prefer them off.
binbandit
force-pushed
the
fix/reenable-matchparen-matchit
branch
from
074e041 to
1847bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lua/blak/lazy.luadisabled the built-inmatchparenandmatchitplugins in lazy.nvim'sperformance.rtp.disabled_plugins. The startup win is negligible (~1ms), and the cost is invisible: stock Neovim highlights the matching bracket under the cursor and ships extended%matching, and Blak silently didn't — with nothing in core replacing either. For a distro whose manifesto opens with "we use native Neovim first" and "we do not hide configuration behind magic", this was a contract violation.This re-enables both. The remaining disabled plugins are kept deliberately:
netrwPluginis explicitly replaced by Oil, andgzip/tarPlugin/tohtml/tutor/zipPluginare genuinely dead weight. A comment inlazy.luanow records that rationale.Per the contract this is a visible default change, so it ships with a NEWS.md entry (new
Unreleasedsection) that includes the opt-out for users who prefer the old behavior:vim.g.loaded_matchparen = 1/vim.g.loaded_matchit = 1in ahooks.beforefunction (verified thathooks.beforeruns during config setup, before plugin bootstrap, so the guards take effect).Validation
make validatepasses. Neovim isn't available here formake smoke; manual check: start Blak, put the cursor on a bracket and confirm the match highlights, and check%jumps acrossif/endifstyle pairs in a vim file.