Upgrade jQuery, jQuery UI, and SlickGrid to latest stable versions - #822
Conversation
(Using a linter this time!)
|
It might be necessary to merge #823 before this one since not all the old versions of the tests work with jQuery 3. |
ElDeveloper
left a comment
ElDeveloper
left a comment
There was a problem hiding this comment.
@actapia Thank you so much, everything looks in good shape except for the tests and the icons not showing up in the buttons but I highlighted that in the other PR.
Only outstanding thing is to have the tests added back but I think that to avoid headaches we should wait until all comments are resolved.
| self.assertTrue(isinstance(obs, Template)) | ||
| self.assertTrue(obs.filename.endswith('/jupyter-template.html')) | ||
|
|
||
| def test_render_style(self): |
There was a problem hiding this comment.
Can you re-add these tests? I would wait until this and the other PR are settled (to avoid having to update the test strings) though.
There was a problem hiding this comment.
Okay. I've restored those tests and updated the test strings to reflect the changes needed for the updates in this PR.
|
thanks @actapia! |
2 participants
These changes update jQuery, jQuery UI, and SlickGrid to the latest stable versions as of this writing (versions 3.7.1, 1.14.1, and 5.15.4, respectively) and make necessary changes to allow Emperor to work with the new versions, addressing part of #820 . The changes add Sortable.js (now a dependency of SlickGrid) and remove jquery-drag (no longer a dependency of SlickGrid).
These commits also remove a few Python test cases that require EMPeror to produce exact HTML, CSS, or JavaScript output, since these tests will fail any time one or more of the JavaScript dependencies is updated.