dont_check_names used for data.frame and data.table evidence_file#152
Open
bpolacco wants to merge 2 commits intobiodavidjm:masterfrom
Open
dont_check_names used for data.frame and data.table evidence_file#152bpolacco wants to merge 2 commits intobiodavidjm:masterfrom
bpolacco wants to merge 2 commits intobiodavidjm:masterfrom
Conversation
Contributor
Author
|
I'd support changing the argument dont_check_names to check_names in the function .checkIfFile for easier to understand code, but that is potentially a mess if its called places I didn't find, so I didn't use that as my fix. |
Contributor
Author
|
Its all good now with my second commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered a problem in .artms_checkIfFile that was using dont_check_names the opposite that the name implies (beware double negative). The only function to use this argument that I found (grep dont_check_names ./R/*) was protein2SiteConversion which was also using it opposite of the name, so no effective bug in usage. However, there was a bug when a data.table or data.frame was passed in to protein2SiteConversion as the evidence file: no check.names argument was passed to data.frame() or data.table() so that names were always checked. The function protein2SiteConversion uses names with spaces, e.g. "Leading proteins", so check.names should be FALSE in calls to read.delim(), data.table(), data.frame().
My changes are