Add GammaHex board support - #1807
Conversation
# Conflicts: # main/device_config.h # main/global_state.h # main/main.c # main/screen.c # main/self_test/self_test.c # main/system.c # main/task_monitor.c # main/tasks/asic_result_task.c
| BM1370_init_core_register_delay(); | ||
|
|
||
| // Present in the S21 XP init between core register control and analog mux. | ||
| _send_BM1370((TYPE_CMD | GROUP_ALL | CMD_WRITE), (uint8_t[]){0x00, 0x14, 0x00, 0x00, 0x00, 0xFF}, 6, BM1370_SERIALTX_DEBUG); |
There was a problem hiding this comment.
Why not do the delay inside _send_BM1370?
There was a problem hiding this comment.
_send_BM1370() is also used for normal mining jobs and register reads, so adding an unconditional 10 ms delay there would throttle runtime traffic. The delay is only needed between specific initialization register writes.
There was a problem hiding this comment.
this delay needs to be tested also on single asic chips, will do that
| return ESP_ERR_INVALID_ARG; | ||
| } | ||
|
|
||
| if (state->DEVICE_CONFIG.family.id == GAMMA_610 || state->DEVICE_CONFIG.family.id == GAMMA_HEX) { |
There was a problem hiding this comment.
It would be cleaner if there is a disable_bap bool flag in device_config. This would be false by default so it only needs to be set to true on this model.
|
Not sure what to make of this, it's quite a code-dump. Some questions:
|
# Conflicts: # main/http_server/axe-os/src/app/components/edit/edit.component.html
|
The C representation avoids enabling a PNG decoder and doing runtime decompression. |
|
I think I fixed most of your concerns @mutatrum, ready for another review. |
3 participants
Summary
Testing