Closed
Conversation
Cbp420
approved these changes
Jan 8, 2023
Added bech32 and bech32m address types to reflect the newer SegWit and Taproot addresses. Co-Authored-By: Reese Russell <reese.russell@ymail.com>
dplusplus1024
force-pushed
the
patch-3
branch
from
b629f06 to
3114974
Compare
|
Any thoughts about this? |
luke-jr
added
the
Proposed BIP modification
Member
|
Normally Final BIPs can't be changed, but I agree it seems like this is more of a clarification than a change. @TheBlueMatt @tcatm what do you think? |
|
I suppose this is okay. BIP-21 experienced alterations in the past which should not have occurred either. A better approach could involve replacing BIP-21 with a new one. |
Member
|
This seems potentially compatible with #1555. What do you think, @TheBlueMatt? |
murchandamus
added
the
Pending acceptance
Contributor
|
Yea, will include this commit there, assuming we move forward with #1555. |
5twelve
approved these changes
Jun 20, 2024
5twelve
approved these changes
Jun 20, 2024
Member
|
Closing for now in favor of #1555 that replaces BIP21, happy to re-open if requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added bech32 and bech32m address types to reflect the newer SegWit and Taproot addresses.