scripts: deduplicate leading-whitespace validation in buildtable.pl #2081
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No thanks. This is not a substantial improvement, but a stylistic preference. This is the third busywork pull request you have opened to this repository. Stop wasting our time with AI-powered commit farming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$val =~ /^\s/validation while parsing BIP preamble fields inscripts/buildtable.pl.The same leading-whitespace condition was checked in two places, which is easy to let drift over time and makes the parsing logic harder to follow. Consolidating it removes duplicate code without changing behavior.