Skip to content

[codex] Build typed global search results#173

Merged
tobomobo merged 1 commit into
mainfrom
codex/search-ux-taxonomy
May 25, 2026
Merged

[codex] Build typed global search results#173
tobomobo merged 1 commit into
mainfrom
codex/search-ux-taxonomy

Conversation

@tobomobo
Copy link
Copy Markdown
Contributor

Summary

  • Extract global search result types, ranking, transaction lookup state, and app result building into ui-tauri/src/components/kb/search/.
  • Add explicit result categories for pages, actions, transactions, wallets, review items, settings, and reports, with privacy tiers and icons.
  • Improve txid search UX with exact match, partial match, multiple-match, loading, and no-local-match states; default Enter on an exact txid opens the transaction drawer while arrow-key selection still controls Enter.
  • Add local action/entity search for journal processing, wallet setup, BTCPay setup, report export, logs, passphrase settings, settings sections, wallet labels, and safe overview transaction metadata.

Validation

  • pnpm --dir ui-tauri exec vitest run src/components/kb/search/ranking.test.ts src/lib/transactionLookup.test.ts
  • pnpm --dir ui-tauri run typecheck
  • Browser check on http://127.0.0.1:5176: exact txid Enter opens /transactions?tx=tx1 with the detail drawer, no-match txid state renders, BTCPay search opens the setup dialog, and arrow-key Enter follows the highlighted result.
  • Independent reviewer re-check: no remaining P1/P2 blockers.
  • ./scripts/quality-gate.sh

@tobomobo tobomobo force-pushed the codex/search-ux-taxonomy branch from ced8e5e to 95c15d8 Compare May 25, 2026 11:43
@tobomobo tobomobo marked this pull request as ready for review May 25, 2026 11:52
@tobomobo tobomobo merged commit 982f8bd into main May 25, 2026
3 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95c15d8b53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +228 to +233
}

const tokens = normalized.split(/[^a-z0-9:_-]+/).filter(Boolean);
if (
profile.terms.every((term) =>
tokens.some((token) => token === term || token.startsWith(term)),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match multi-term queries across all searchable fields

The new ranking logic only accepts a result when all query terms are found inside a single field (title, subtitle, one keyword, etc.), because matchTextField evaluates one field at a time and bestTextMatch never combines evidence across fields. This regresses searches where terms are intentionally split across fields (for example, "home dashboard" for Overview, where both are separate keywords), so valid results are now dropped even though all terms exist on that result.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant