[codex] Page transactions from daemon#174
Conversation
1965fda to
e723a27
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e723a274fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| order=order, | ||
| filters=cursor_filters, | ||
| ) | ||
| skip_pairs = set(cursor_data.get("skip_pairs", [])) if cursor_data else set() |
There was a problem hiding this comment.
Validate cursor skip_pairs entries before converting to set
Converting cursor_data["skip_pairs"] directly with set(...) allows non-hashable JSON values (for example, a tampered cursor containing [{"x":1}]) to raise a raw TypeError instead of the expected validation AppError. This breaks the daemon’s error-envelope contract for malformed cursors and surfaces as an internal failure path rather than a user-correctable validation error; the cursor decoder should either enforce skip_pairs as a list of strings or catch TypeError and rethrow AppError(code="validation").
Useful? React with 👍 / 👎.
Summary
ui.transactions.listand reuse the same backend path forui.transactions.search./transactionsoff the initiallimit: 500fetch by using a daemon-backed infinite query and a Load more table affordance.Validation
UV_CACHE_DIR=/tmp/kassiber-uv-cache uv run python -m unittest tests.test_review_regressions.ReviewRegressionTest.test_ui_snapshots_show_reviewed_swap_movement_with_fee tests.test_daemon_smoke.DaemonSmokeTest.test_daemon_safe_read_tool_kinds_return_workspace_statepnpm --dir ui-tauri run typecheckpnpm --dir ui-tauri exec vitest run src/daemon/client.test.tsHOME=/tmp/kassiber-quality-home UV_CACHE_DIR=/tmp/kassiber-uv-cache ./scripts/quality-gate.sh