refactor(types): prototype inner-wrapper macro#51
Draft
darioAnongba wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impl_inner_wrapper!macro for tuple wrappers that only needDerefplusFromconversionswasm_bindgenmethods and getters explicit so the generated JS and TS surface stays easy to readWhy this slice
Issue #25 is broad, so this PR intentionally takes the smallest safe slice first. It targets the truly repetitive structural boilerplate and leaves field-forwarding methods explicit.
I did not introduce a proc macro here because that would add substantially more maintenance complexity for a small amount of repetition.
Refs #25
Validation
cargo fmt --checkcargo clippy --all-features --all-targets -- -D warningscargo test --all-featurescd tests/node && corepack yarn lintcd tests/node && corepack yarn build(blocked in this environment becauseclangis not installed for thewasm32-unknown-unknownbuild path)