test: include derivation test when private key has leading zeros#673
Merged
Conversation
This was referenced Oct 20, 2016
Contributor
|
Probably would add this as a test fixture instead, but sure? Was there any reason why this might not work? |
Contributor
Author
|
All of the tests will currently pass if the 32 is removed from line this.keyPair.d.toBuffer().copy(data, 1)Instead of: this.keyPair.d.toBuffer(32).copy(data, 1)So this test covers that case. There may be one more at, that isn't covered: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/hdnode.js#L193 Most of the fixtures have a seed, the seed is unknown here. |
dcousens
pushed a commit
that referenced
this pull request
Oct 21, 2016
dcousens
pushed a commit
that referenced
this pull request
Oct 21, 2016
Contributor
Contributor
|
Whatever, we'll merge both |
dcousens
pushed a commit
that referenced
this pull request
Oct 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.