Include type definitions in the package #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any chance to publish an new version ? |
Collaborator
|
@gabmontes can you pls pour fresh master into your branch? im hoping it will fix all failing CI jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types were added in #77 but not included in the NPM package, therefore type checking cannot be properly done. This is the error usually thrown by TypeScript:
Including the type definitions file in the package as done in ChrisCho-H@f173732 and publishing a new version will solve the problem.
Note that I didn't bump the package version in this PR but happy to do so if that would help.
Possibly related to #85 too.