Skip to content

Web roundup: blank /sdoh route, stale TODAY_ISO, unsupported 'urgent' priority, role-inconsistent sidebar, fabricated CostROI numbers #64

Description

@manjula25

Summary

Low-priority frontend issues found in the review, batched together.

Items

  1. Blank /sdoh route (pages/Sdoh.tsx:149-150): resource cards render only for a selected patient; the patientless /sdoh route (reachable from the mobile "Resources" tab, MobileNav.tsx:38) shows category tabs over an empty page with no explanation.
  2. Stale "today" (pages/TaskQueue.tsx:66): TODAY_ISO is a module-load constant — overdue/"today" filters go stale across midnight in a long-lived tab.
  3. Unsupported urgent priority (pages/TaskManagement.tsx:102-122): the New Task form offers urgent, which isn't in the TaskListEntry['priority'] union — PRIORITY_LABEL['urgent'] renders an empty pill, and the created task gets a local- id that vanishes on the next refetch while the toast claims "Task created".
  4. Role-inconsistent navigation (components/Sidebar.tsx:74): "Cost/ROI" is shown to all roles but the route is director-only (App.tsx:97-104) — non-directors get bounced to their home.
  5. Fabricated data without a demo badge: components/Header.tsx:70 hardcodes "Last synced 42s ago" and a badge count of "3"; pages/CostROI.tsx is 100% fabricated financial/HEDIS numbers with no DemoFallbackBadge, contradicting the codebase's own documented honesty rule (G4) that every other page follows.
  6. Unreachable fallbacks (pages/Governance.tsx:179-202): the MOCK_AUDIT_TRAIL/MOCK_MODEL_PERFORMANCE/MOCK_PARITY fallbacks can never render — the component is gated on !isError, so on error the user sees the red error line, never the fallback the variables were built for.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions