fix(skills): store gate scripts as real files, not symlinks - #312
Merged
Conversation
Per-skill-dir installers reject paths that escape the skill root. Replace the 4 symlinks with identical copies. Add check-skill-links.sh (with tests) to block escaping links. Wire the check into lint and CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the 4 skill gate-script symlinks with identical file copies, so per-skill-dir installers no longer reject the skills with 'skill package path escapes source root'.
Closes #311
Changes:
Verification:
Note: the skill copies can drift from the scripts/ root copies. A sync check is possible later. This PR keeps scope to the issue.