Skip to content

Apply pattern matching for instanceof across codebase #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristianHoesel merged 2 commits into from
Nov 18, 2025
Merged

Apply pattern matching for instanceof across codebase #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a440965
Initial plan
Copilot Nov 18, 2025
901819f
Apply pattern matching for instanceof (Java 17 feature)
Copilot Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/bitctrl/resource/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ public Set<String> stringPropertyNames() {

final Set<String> keys = new HashSet<>();
for (final Object key : configuration.keySet()) {
if (key instanceof String) {
keys.add((String) key);
if (key instanceof final String stringKey) {
keys.add(stringKey);
}
}
return keys;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/bitctrl/rmi/RemoteTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public static void init(final StoppableApplication application, final String[] a
} catch (final NotBoundException ex) {
throw new IllegalStateException(ex);
} catch (final UnmarshalException ex) {
if (ex.getCause() instanceof SocketException) {
if (ex.getCause() instanceof final SocketException socketEx) {
// Verbindungsabruch, weil Applikation beendet wurde
System.exit(0);
} else {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/bitctrl/util/TreeProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,8 @@ public Set<String> stringPropertyNames() {

final Set<String> keys = new HashSet<>();
for (final Object key : keySet()) {
if (key instanceof String) {
keys.add((String) key);
if (key instanceof final String stringKey) {
keys.add(stringKey);
}
}
return keys;
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/bitctrl/util/monitor/SubMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@ public static SubMonitor convert(IMonitor monitor, final String taskName, final

// Optimization: if the given monitor already a SubMonitor, no
// conversion is necessary
if (monitor instanceof SubMonitor) {
monitor.beginTask(taskName, work);
return (SubMonitor) monitor;
if (monitor instanceof final SubMonitor subMonitor) {
subMonitor.beginTask(taskName, work);
return subMonitor;
}

monitor.beginTask(taskName, MINIMUM_RESOLUTION);
Expand Down