Skip to content

build: resolve transitive external path dependencies in rules_rs - #1070

Merged
snowp merged 3 commits into
mainfrom
codex/rules-rs-external-path-dependencies
Aug 12, 2026
Merged

snowp merged 3 commits into
mainfrom
codex/rules-rs-external-path-dependencies

Conversation

@snowp

@snowp snowp commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Updates the local rules_rs patch to mirror hermeticbuild/rules_rs#199.

The patch walks direct and transitive external path manifests with cargo metadata --no-deps, so Cargo workspaces outside the capture-sdk workspace can use inherited dependency declarations. It avoids loading a complete external dependency graph and does not attempt to watch manifests outside the Bazel workspace.

@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 86dfcab to 7c8c738 Compare July 24, 2026 18:15
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 7c8c738 to b68e15b Compare August 5, 2026 12:34
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Android Size Comparison Report (x86_64)

Metric APK (KB) SO (KB)
Baseline 3444 1344
Current 3448 1344
Difference 4 0

APK size increased by 4 KB. SO size unchanged.

@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from b68e15b to 4c37df6 Compare August 5, 2026 12:57
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 4c37df6 to f345d4a Compare August 5, 2026 13:04
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from f345d4a to 80f23a6 Compare August 5, 2026 13:09
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 80f23a6 to 577962d Compare August 5, 2026 13:20
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Android Benchmark Results

Device: PR: Emulator - Android SDK built for x86_64 (API 31) | main: Emulator - Android SDK built for x86_64 (API 31)

Note: Benchmarks run on emulator. Results may vary between runs and may differ from physical devices.

Allocations

Test PR main Δ
clearEntityId 0 0 0.0%
getSdkStatus 1 1 0.0%
logAppLaunchTTI 0 0 0.0%
logHttpNetworkLog50FieldsAndHeadersAndFieldProviders 1075 878 +22.4%
logNotMatched5000Fields 10 10 0.0%
logNotMatchedNoFields 1 1 0.0%
loggerImplCreation 501 501 0.0%
processJvmCrash 2066 2066 0.0%
processNativeCrash 2943 2943 0.0%
setEntityId 0 0 0.0%
startNewSession 22 22 0.0%
trackSpansWithFields 359 359 0.0%
trackSpansWithoutFields 55 56 -1.8%
webViewBridgeBridgeReady 60 59 +1.7%
webViewBridgeInvalidJson 38 38 0.0%

Timing

Test PR main Δ
clearEntityId 133 ns 94 ns +42.2%
getSdkStatus 181 ns 135 ns +34.3%
logAppLaunchTTI 80 ns 60 ns +34.6%
logHttpNetworkLog50FieldsAndHeadersAndFieldProviders 268.70 us 284.37 us -5.5%
logNotMatched5000Fields 2.92 ms 2.78 ms +4.9%
logNotMatchedNoFields 481 ns 505 ns -4.6%
loggerImplCreation 2.04 ms 1.33 ms +53.9%
processJvmCrash 365.04 us 270.75 us +34.8%
processNativeCrash 358.90 us 262.27 us +36.8%
setEntityId 413 ns 576 ns -28.3%
startNewSession 5.45 ms 5.42 ms +0.5%
trackSpansWithFields 575.48 us 716.85 us -19.7%
trackSpansWithoutFields 8.52 us 8.16 us +4.5%
webViewBridgeBridgeReady 8.05 us 7.06 us +13.9%
webViewBridgeInvalidJson 65.17 us 87.62 us -25.6%

@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 577962d to ed95de2 Compare August 5, 2026 13:42
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

iOS Size Comparison Report

Metric Thinned App Size (KB) Capture SDK Binary (KB)
Baseline 3277 63393
Current 3277 63392
Difference 0 -1

Thinned app size unchanged.
Capture SDK binary size decreased by 1 KB.

@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from ed95de2 to 1629184 Compare August 5, 2026 14:16
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 1629184 to f88d030 Compare August 10, 2026 17:51
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from f88d030 to 41625ce Compare August 10, 2026 18:37
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 41625ce to f1e2013 Compare August 10, 2026 18:39
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from f1e2013 to ea9a021 Compare August 10, 2026 18:52
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from ea9a021 to f424565 Compare August 10, 2026 20:27
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from f424565 to f75e191 Compare August 10, 2026 21:17
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from f75e191 to fd297d9 Compare August 11, 2026 20:50
@snowp snowp changed the title build: support external path dependencies in rules_rs build: resolve transitive external path dependencies in rules_rs Aug 12, 2026
Base automatically changed from codex/migrate-rules-rs to main August 12, 2026 14:37
snowp and others added 3 commits August 12, 2026 08:37
Co-Authored-By: GPT-5.6 <codex@openai.com>
Co-Authored-By: GPT-5.6 <codex@openai.com>
Co-Authored-By: GPT-5 <codex@openai.com>
@snowp
snowp force-pushed the codex/rules-rs-external-path-dependencies branch from 1aea25e to 6706119 Compare August 12, 2026 14:37
@snowp
snowp merged commit c269d1a into main Aug 12, 2026
20 checks passed
@snowp
snowp deleted the codex/rules-rs-external-path-dependencies branch August 12, 2026 14:57
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants