[Ktor] Refactor HTTP utilities to use top-level extensions#187
Merged
Conversation
- Create ContentTypeUtils.kt with ContentType extensions (isText, isXml) and String.toContentTypeOrNull() - Add String.toUrlOrNull() extension to UrlUtils.kt - Rename KtorHttpUtils.kt to HttpUtils.kt and object to HttpUtils - Update all usages of KtorHttpUtils to HttpUtils in DavResource.kt, Response.kt, ResponseParser.kt, PropStatParser.kt - Create ContentTypeUtilsTest.kt with tests for ContentType extensions - Rename KtorHttpUtilsTest.kt to HttpUtilsTest.kt - Add tests for toUrlOrNull to UrlUtilsTest.kt - Update deprecation in OkHttpUtils.kt to point to HttpUtils This follows the same pattern as the UrlUtils.kt refactor, using top-level extension methods where appropriate and grouping related utilities into semantic files. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
KtorHttpUtilstoHttpUtilswith top-level extension functions, following the same pattern asUrlUtils. This includes:ContentTypeextensions (isText,isXml) andString.toContentTypeOrNull()toContentTypeUtils.ktString.toUrlOrNull()toUrlUtils.ktDavResource.kt,Response.kt,ResponseParser.kt, andPropStatParser.ktContentTypeUtilsTest.ktandUrlUtilsTest.ktOkHttpUtils.ktto point toHttpUtils