This repository was archived by the owner on Jun 20, 2023. It is now read-only.
remove empty curly brackets from namespace manifest#71
Open
bfarayev wants to merge 1 commit into
Open
Conversation
jbianquetti-nami
approved these changes
Feb 25, 2022
jbianquetti-nami
left a comment
jbianquetti-nami
left a comment
Contributor
There was a problem hiding this comment.
SGTM because they are cosmetic changes
jbianquetti-nami
requested review from
Akinorev
and removed request for
dbarranco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems like having an empty curly brackets is breaking the styling in IDEs like IntelliJ (haven't tested in VS Code)
I get this error message:
This also breaks the "Go to Declaration" when we're using this an object from this library. Removing the curly brackets fixes the issue