fix: stop /v1/verify from acting as a decryption oracle - #2019
Merged
Conversation
alvneiayu
force-pushed
the
fix-plaintext-vuln
branch
from
August 11, 2026 08:13
6a19c32 to
f91092f
Compare
agarcia-oss
previously approved these changes
Aug 17, 2026
spec.template.data isn't covered by the AEAD label, so /v1/verify's full Unseal() (including template execution) let an attacker pair a victim's real metadata/encryptedData with a crafted template and leak plaintext one bit per request via the 200/409 response. AttemptUnseal now uses a new ValidateEncryptedData() that only checks decryptability and never renders templates. Signed-off-by: Alvaro Neira <alvaro.neira@broadcom.com>
alvneiayu
force-pushed
the
fix-plaintext-vuln
branch
from
August 17, 2026 10:16
f91092f to
ce6bbde
Compare
agarcia-oss
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.template.data isn't covered by the AEAD label, so /v1/verify's full Unseal() (including template execution) let an attacker pair a victim's real metadata/encryptedData with a crafted template and leak plaintext one bit per request via the 200/409 response. AttemptUnseal now uses a new ValidateEncryptedData() that only checks decryptability and never renders templates.