Skip to content

Add imports to force vendoring required codegen tools - #2020

Open
meln5674 wants to merge 1 commit into
bitnami:mainfrom
meln5674:fix/missing-codegen-vendor
Open

Add imports to force vendoring required codegen tools#2020
meln5674 wants to merge 1 commit into
bitnami:mainfrom
meln5674:fix/missing-codegen-vendor

Conversation

@meln5674

@meln5674 meln5674 commented Aug 16, 2026

Copy link
Copy Markdown

Description of the change

Add imports to force vendoring of tools required by ./hack/update-codegen.sh.

For whatever reason, only a subset of k8s.io/code-generator/cmd/ are vendored. This fails when k8s.io/code-generator/update-codegen.sh attempts to run

go install k8s.io/code-generator/cmd/conversion-gen k8s.io/code-generator/cmd/deepcopy-g
en k8s.io/code-generator/cmd/defaulter-gen k8s.io/code-generator/cmd/validation-gen

which fails because k8s.io/code-generator/cmd/validation-gen is not vendored.

Benefits

Currently, running make generate on main fails with

andrew:sealed-secrets$ make generate
go mod vendor
./hack/update-codegen.sh
cannot find module providing package k8s.io/code-generator/cmd/validation-gen: import look
up disabled by -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [Makefile:50: generate] Error 1

With this change, make generate now succeeds.

Possible drawbacks

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Andrew Melnick <meln5674@kettering.edu>
@meln5674
meln5674 force-pushed the fix/missing-codegen-vendor branch from 4993252 to a0fcd9b Compare August 16, 2026 21:37
@meln5674 meln5674 changed the title add imports to force vendoring required codegen tools Add imports to force vendoring required codegen tools Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant