This repository was archived by the owner on Apr 3, 2019. It is now read-only.
[Ready for testing] Fix validation to look for any wordlist with a valid checksum#36
Open
dabura667 wants to merge 5 commits intobitpay:masterfrom
Open
[Ready for testing] Fix validation to look for any wordlist with a valid checksum#36dabura667 wants to merge 5 commits intobitpay:masterfrom
dabura667 wants to merge 5 commits intobitpay:masterfrom
Conversation
Contributor
|
Interesting find! |
Contributor
Author
|
Ready for testing / merge if all is fine. |
Contributor
Author
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bitpay/copay/issues/3211 and will allow for wordlists that have common words in different positions.
This fix will be especially necessary if zh_CN and zh_TW wordlists will both be supported someday, as they have many words in common.
for reference, here are 3 mnemonics only using the common words between English and French. This will help in testing.