Skip to content

Fix client server number rounding#4188

Open
kajoseph wants to merge 8 commits into
bitpay:masterfrom
kajoseph:fixClientServerNumberRounding
Open

Fix client server number rounding#4188
kajoseph wants to merge 8 commits into
bitpay:masterfrom
kajoseph:fixClientServerNumberRounding

Conversation

@kajoseph

@kajoseph kajoseph commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Description

CWC's toHex util provided inconsistent conversions for large Numbers.

Changelog

  • Adds a special conversion for Numbers in CWC's toHex util function.
  • Adds round-trip tests for TXPs in BWC.
  • Adds typing to BWS's getSendMaxInfo() methods
  • Adds numberFormat params to getTx and getSendMaxInfo methods in both BWC & BWS
  • Fixes client-side verification method(s) when verifying string/hex numbers.
  • Fixes some incidental issues:
    • Fixed bitcore-client's deleteWallet idempotence
    • Fixed ci.sh local test runner creating the build dirs as root

Testing Notes

Add any helpful notes for reviewers to test your code here.


Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

@kajoseph kajoseph added BWC This pull request modifies the bitcore-wallet-client package BWS This pull request modifies the bitcore-wallet-service package CWC This pull request modifies the crypto-wallet-core package labels Jul 3, 2026
@kajoseph kajoseph added the BCC This pull request modifies the bitcore-client package label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCC This pull request modifies the bitcore-client package BWC This pull request modifies the bitcore-wallet-client package BWS This pull request modifies the bitcore-wallet-service package CWC This pull request modifies the crypto-wallet-core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant