conditionally set WORK_DIR if undefined and execute post-relocate if it exists
#71
Conversation
| ' WORK_DIR=$(realpath "${BASH_SOURCE[0]:-$0}" | sed "s|/$BITS_ARCH_PREFIX.*||")', | ||
| ' export WORK_DIR', | ||
| 'fi', | ||
| ]) |
There was a problem hiding this comment.
@akritkbehera , as the new relocation logic can relocated init.*sh files so why not use
WORK_DIR=<build/work/directory> . the relocation can change it to WORK_DIR=<deploydirectory> ?
@ktf , what was the logic of setting WORK_DIR from outside? Can't we just hard-code it with proper relocation ?
There was a problem hiding this comment.
The idea is that you do not need aliBuild to do the relocation of packages and loading of the environment, so everything related to that must work with WORK_DIR being set from the outside.
There was a problem hiding this comment.
thanks @ktf , I understand that. But you still need some tool/script to deploy the pre-build packages and that tool will run the relocation .... right? If yes then why not just relocate init.*sh too?
There was a problem hiding this comment.
one benefit I see with setting WORK_DIR externally is that one can just symlink a pre-installed/deployed package from CVMFS in to local build area and its ${<PKG>_ROOT} will properly point to WORK_DIR/pkg-path.
I am fine with change in the PR. This will allow
- bits/alibuild to use pre-deployed packages from cvmfs ( as bits/alibuild set
WORK_DIR) by just symlinking them - No need to set WORK_DIR for setting up package env directly from deployed area as default WORK_DIR in packages' init file will be properly relocated
There was a problem hiding this comment.
The goal was to avoid relocation as much as possible. That way just untarring the tarballs would have given you a working environment.
akritkbehera
force-pushed
the
Post_relocate
branch
from
8e2d898 to
e3d4cf2
Compare
…sh` if present. pass work directory directly to `generate_initdotsh` instead of deriving it dynamically. Test Case Fix
akritkbehera
force-pushed
the
Post_relocate
branch
from
e3d4cf2 to
e031704
Compare
4 participants
#Description:
WORK_DIR: init.sh now automatically calculates WORK_DIR relative to its location. This allows the script to be sourced directly without manually exporting WORK_DIR beforehand.