Conversation
| }) | ||
|
|
||
| const mapDispatchToProps = (dispatch) => ({ | ||
| setLocation: (location) => dispatch(updateLocation(location)) |
Collaborator
There was a problem hiding this comment.
you could just use react-router-redux https://www.npmjs.com/package/react-router-redux :)
| } | ||
|
|
||
| const mapStateToProps = (state) => ({ | ||
| location: state.nav.location |
Collaborator
There was a problem hiding this comment.
location from props is never used so you can safely remove it
| <Card key={data_entry.title} title={data_entry.title} number={data_entry.number} ranking={data_entry.ranking} daily={data_entry.daily} /> | ||
| )} | ||
| {Object.values(entry.covidinfo) | ||
| .filter( |
Collaborator
There was a problem hiding this comment.
Don't put so much logic inside of markup. Consider refactoring this piece
| }); | ||
|
|
||
| const mapDispatchToProps = (dispatch) => ({ | ||
| setError: (value) => dispatch(updateError(value)), |
| ) { | ||
| return countries; | ||
| } | ||
| return countries.filter( |
Collaborator
There was a problem hiding this comment.
just a suggestion:
const startsWithCountryName = (value) => value.toLowerCase().startsWith(countryName);
return countries.filter(({ country, iso2, iso3 }) =>
startsWithCountryName(country) ||
startsWithCountryName(iso2) ||
startsWithCountryName(iso3)
);
| }); | ||
|
|
||
| } | ||
| this.props.setValue(event.target.value); |
Collaborator
There was a problem hiding this comment.
Ok for test project, but in your case it doesn't make a lot of sense to process input through redux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.